Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14196 | Set idv_consent_given_at timestamp #11164

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

n1zyy
Copy link
Member

@n1zyy n1zyy commented Aug 29, 2024

🎫 Ticket

Link to the relevant ticket:
LG-14196

🛠 Summary of changes

This is the first of a two-part series; part 1 needs to be released before part 2.

Socure's API requires us to pass the time when a user consented to IdV. We currently store a boolean, idv_consent_given, on the user session, tracking whether they have agreed to sharing their data for IdV. This moves to storing a timestamp, idv_consent_given_at, so that we can stop answering "When did the user consent?" with "Yes." (Pragmatically, because it's stored on the session, we know they consented very recently. But we should store the actual timestamp.)

N.B. also that we are not currently sending any data to Socure in production environments; it is all feature-flagged off.

I am currently leaving the old idv_consent_given logic intact. We can release this and start setting idv_consent_given_at in sessions.

The second PR, after it's being set on new sessions, will replace the existing idv_consent_given boolean logic with checking the timestamp instead.

I expanded the AgreementController test to assert that it was set correctly. The not-nil idv_consent_given assertion will be short-lived, but it's correct for now.

This will be part 1 of a 2-part series.

changelog: Internal, Socure, Set idv_consent_given_at on session
@n1zyy n1zyy merged commit 9133d68 into main Aug 29, 2024
2 checks passed
@n1zyy n1zyy deleted the mattw/LG-14196_idv_consent_given_at branch August 29, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants